Skip to content

West-Midlands | 26-May-ITP | Maryam Janjua | Sprint 2 | Wireframe To Web Code - #1442

Open
maryam-devio wants to merge 2 commits into
CodeYourFuture:mainfrom
maryam-devio:feature/wireframe
Open

West-Midlands | 26-May-ITP | Maryam Janjua | Sprint 2 | Wireframe To Web Code#1442
maryam-devio wants to merge 2 commits into
CodeYourFuture:mainfrom
maryam-devio:feature/wireframe

Conversation

@maryam-devio

@maryam-devio maryam-devio commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • I completed the webpage according to the wireframe instructions.
  • I used semantic HTML elements to structure the page.
  • I created three articles, each with an image, title, summary, and link.
  • I styled the page using an external CSS file and matched the wireframe layout as closely as possible.
  • I validated my HTML code and confirmed there are no errors.
  • I checked the page with Lighthouse and achieved a score of 100 for Accessibility.

@netlify

netlify Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit d8463ed
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2ac61a5a947100088149e0
😎 Deploy Preview https://deploy-preview-1442--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@maryam-devio maryam-devio added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 11, 2026
@maryam-devio maryam-devio mentioned this pull request Jun 11, 2026
Open
cjyuan
cjyuan reviewed Jun 11, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well formatted and error-free, and page layout matches the wireframe well.

Can you use different images among the articles to fully meet the requirements listed in the README?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 11, 2026
@maryam-devio maryam-devio added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@maryam-devio

maryam-devio commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi! Thank you for your feedback. I have added three different images. Can you please review it? Thanks

@maryam-devio

maryam-devio commented Jun 11, 2026

Copy link
Copy Markdown
Author

Code is well formatted and error-free, and page layout matches the wireframe well.

Can you use different images among the articles to fully meet the requirements listed in the README?

Thank you for your feedback. I have added three different images. Can you please review it? Thanks.

@maryam-devio maryam-devio removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jun 11, 2026
@cjyuan

cjyuan commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 11, 2026
@maryam-devio maryam-devio mentioned this pull request Jun 11, 2026
Open
@maryam-devio maryam-devio added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jun 11, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 11, 2026
@cjyuan

cjyuan commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

You shouldn't touch the "Complete" label.

@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

@Poonam-raj Poonam-raj reopened this Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Your PR didn't include a Task ID in its description.

Make sure you have put the correct Task ID in its description.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maryam-devio @cjyuan @illicitonion @Poonam-raj